From: Dan Carpenter Date: Thu, 5 May 2016 13:23:04 +0000 (+0300) Subject: ACPI / sysfs: fix error code in get_status() X-Git-Tag: v3.2.82~79 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae9dc44c3756db582c72e638c872391944b58968;p=pandora-kernel.git ACPI / sysfs: fix error code in get_status() commit f18ebc211e259d4f591e39e74b2aa2de226c9a1d upstream. The problem with ornamental, do-nothing gotos is that they lead to "forgot to set the error code" bugs. We should be returning -EINVAL here but we don't. It leads to an uninitalized variable in counter_show(): drivers/acpi/sysfs.c:603 counter_show() error: uninitialized symbol 'status'. Fixes: 1c8fce27e275 (ACPI: introduce drivers/acpi/sysfs.c) Signed-off-by: Dan Carpenter Signed-off-by: Rafael J. Wysocki Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed