From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 9 Mar 2011 13:14:26 +0000 (+0100)
Subject: netfilter: x_tables: misuse of try_then_request_module
X-Git-Tag: v2.6.39-rc1~468^2~26^2~35
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=adb00ae2ea0ec65f9d3d06079950c0f0ade3b614;p=pandora-kernel.git

netfilter: x_tables: misuse of try_then_request_module

Since xt_find_match() returns ERR_PTR(xx) on error not NULL,
the macro try_then_request_module won't work correctly here.
The macro expects its first argument will be zero if condition
fails. But ERR_PTR(-ENOENT) is not zero.

The correct solution is to propagate the error value
back.

Found by inspection, and compile tested only.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---

Reading git-diff-tree failed