From: Jeff Layton Date: Fri, 15 Oct 2010 19:33:58 +0000 (-0400) Subject: cifs: eliminate the inode argument from cifs_new_fileinfo X-Git-Tag: v2.6.37-rc1~158^2~11 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=abfe1eedd682ea0f20e7035445982e6d371a2024;p=pandora-kernel.git cifs: eliminate the inode argument from cifs_new_fileinfo It already takes a file pointer. The inode associated with that had damn well better be the same one we're passing in anyway. Thus, there's no need for a separate argument here. Also, get rid of the bogus check for a null pCifsInode pointer. The CIFS_I macro uses container_of(), and that will virtually never return a NULL pointer anyway. Finally, move the setting of the canCache* flags outside of the lock. Other places in the code don't hold that lock when setting it, so I assume it's not really needed here either. Signed-off-by: Jeff Layton Reviewed-by: Suresh Jayaraman Acked-by: Dave Kleikamp Signed-off-by: Steve French --- Reading git-diff-tree failed