From: Michael Ellerman Date: Thu, 1 Sep 2005 01:28:59 +0000 (+1000) Subject: [PATCH] iseries_veth: Remove a FIXME WRT deletion of the ack_timer X-Git-Tag: v2.6.14-rc1~1018^2~16 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=abfda4719c61550be4efaf277d4a904a7930d410;p=pandora-kernel.git [PATCH] iseries_veth: Remove a FIXME WRT deletion of the ack_timer The iseries_veth driver has a timer which we use to send acks. When the connection is reset or stopped we need to delete the timer. Currently we only call del_timer() when resetting a connection, which means the timer might run again while the connection is being re-setup. As it turns out that's ok, because the flags the timer consults have been reset. It's cleaner though to call del_timer_sync() once we've dropped the lock, although the timer may still run between us dropping the lock and calling del_timer_sync(), but as above that's ok. Signed-off-by: Michael Ellerman Signed-off-by: Jeff Garzik --- Reading git-diff-tree failed