From: J. Bruce Fields Date: Mon, 15 Apr 2013 20:03:46 +0000 (-0400) Subject: nfsd: fix EXDEV checking in rename X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~48^2~10 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa387d6ce15330e09037947147c5a5a2ba42a0e8;p=pandora-kernel.git nfsd: fix EXDEV checking in rename We again check for the EXDEV a little later on, so the first check is redundant. This check is also slightly racier, since a badly timed eviction from the export cache could leave us with the two fh_export pointers pointing to two different cache entries which each refer to the same underlying export. It's better to compare vfsmounts as the later check does, but that leaves a minor security hole in the case where the two exports refer to two different directories especially if (for example) they have different root-squashing options. So, compare ex_path.dentry too. Reported-by: Joe Habermann Signed-off-by: J. Bruce Fields --- Reading git-diff-tree failed