From: Krzysztof Kozlowski Date: Tue, 19 May 2015 07:16:29 +0000 (+0900) Subject: power_supply: Use wrappers to avoid races when registering power supply X-Git-Tag: omap-for-v4.2/fixes-rc1^2~149^2~22 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a9f6a19b57c4f37dfd6aa322071948245fecbd91;p=pandora-kernel.git power_supply: Use wrappers to avoid races when registering power supply Use wrappers over get_property() and set_property() internally in power supply and for sysfs interface. The wrappers provide safe access if power supply is not yet registered or t is being destroyed. In case of syfs the theoretical race could happen between ending of driver's probe and parallel sysfs access: some_driver_probe() userspace ==================================== =========================== drv->psy = power_supply_register() device_add() sysfs entries are created atomic_inc(&psy->use_cnt); store on sysfs attributes drv->set_property() dereference of drv->psy drv->psy = returned psy; For leds the race could happen between power supply being destroyed and ongoing power_supply_changed_work(). Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- Reading git-diff-tree failed