From: Pekka Enberg <penberg@cs.helsinki.fi>
Date: Wed, 8 Apr 2009 08:14:00 +0000 (+0300)
Subject: Staging: w35und: more simplify hal_init_hardware() error handling
X-Git-Tag: v2.6.31-rc1~105^2~202
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a39ee671746b6483c6a259fef755a4a3e475e3e4;p=pandora-kernel.git

Staging: w35und: more simplify hal_init_hardware() error handling

Impact: fix, cleanup

If initialization in hal_init_hardware() fails, we call hal_halt() to
clean up and release resource. However, hal_halt() will attempt to
call del_timer_sync() on ->LEDTimer on "stage 3" although it's not
initialized at that point. Fix that up by simplifying error handling
logic in hal_init_hardware() with gotos.

Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

Reading git-diff-tree failed