From: Stephen Hemminger Date: Thu, 29 Nov 2007 14:10:55 +0000 (+1100) Subject: [TCP] illinois: Incorrect beta usage X-Git-Tag: v2.6.24-rc4~8^2~14 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a357dde9df33f28611e6a3d4f88265e39bcc8880;p=pandora-kernel.git [TCP] illinois: Incorrect beta usage Lachlan Andrew observed that my TCP-Illinois implementation uses the beta value incorrectly: The parameter beta in the paper specifies the amount to decrease *by*: that is, on loss, W <- W - beta*W but in tcp_illinois_ssthresh() uses beta as the amount to decrease *to*: W <- beta*W This bug makes the Linux TCP-Illinois get less-aggressive on uncongested network, hurting performance. Note: since the base beta value is .5, it has no impact on a congested network. Signed-off-by: Stephen Hemminger Signed-off-by: Herbert Xu --- Reading git-diff-tree failed