From: Jesper Nilsson Date: Fri, 8 Feb 2008 15:28:36 +0000 (+0100) Subject: CRIS v32: Rewrite ARTPEC-3 gpio driver to avoid volatiles and general cleanup. X-Git-Tag: v2.6.25-rc1~40^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a34d24425e9c133e875a26c0bbc91783cf485b93;p=pandora-kernel.git CRIS v32: Rewrite ARTPEC-3 gpio driver to avoid volatiles and general cleanup. Changes as suggested by Andrew Morton, plus general cleanup to ease later consolidation of driver into machine common driver. - Correct parameter type of gpio_write to const char __user * - Remove volatile from the arrays of machine dependent registers, use readl and writel to access them instead. - Remove useless casts of void. - Use spin_lock_irqsave for locking. - Break gpio_write into smaller sub-functions. - Remove useless breaks after returns. - Don't perform any change in IO_CFG_WRITE_MODE if values are invalid. (previously values were set and then set to zero) - Change cast for copy_to_user to (void __user *) - Make file_operations gpio_fops static and const. - Make setget_output static. (However, it's still inline since the CRIS architecture is still not SMP, which makes the function small enough to inline) --- Reading git-diff-tree failed