From: Robert Baldyga Date: Thu, 9 Oct 2014 07:41:16 +0000 (+0200) Subject: usb: gadget: f_fs: remove redundant ffs_data_get() X-Git-Tag: omap-for-v3.19/fixes-not-urgent-part1~17^2~2^2~12 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a3058a5d82e296daaca07411c3738a9ddd79f302;p=pandora-kernel.git usb: gadget: f_fs: remove redundant ffs_data_get() During FunctionFS bind, ffs_data_get() function was called twice (in functionfs_bind() and in ffs_do_functionfs_bind()), while on unbind ffs_data_put() was called once (in functionfs_unbind() function). In result refcount never reached value 0, and ffs memory resources has been never released. Since ffs_data_get() call in ffs_do_functionfs_bind() is redundant and not neccessary, we remove it to have equal number of gets ans puts, and free allocated memory after refcount reach 0. Fixes: 5920cda (usb: gadget: FunctionFS: convert to new function interface with backward compatibility) Cc: # v3.14+ Signed-off-by: Robert Baldyga Signed-off-by: Felipe Balbi --- Reading git-diff-tree failed