From: Mauro Carvalho Chehab Date: Wed, 26 Nov 2014 13:07:41 +0000 (-0300) Subject: [media] stv090x: remove export symbol for stv090x_set_gpio() X-Git-Tag: omap-for-v3.19/fixes-rc1~133^2~23 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a2ea5561173f5c2c14e6050b261d225acd99fa08;p=pandora-kernel.git [media] stv090x: remove export symbol for stv090x_set_gpio() Drivers that use dvb_attach can have just one exported symbol, or they will cause compilation breakages depending on the selected frontends. As Jim reported: drivers/built-in.o: In function `technisat_usb2_set_voltage': technisat-usb2.c:(.text+0x3b4919): undefined reference to `stv090x_set_gpio' make: *** [vmlinux] Error 1 That happens because, on his configuration, the configuration is: CONFIG_DVB_USB=y CONFIG_DVB_STV090x=m Luis proposed ar way to fix, but that would just force the STV090x to be selected, even if one wants to use a device with a different frontend. Instead, let's do the right thing: move set_gpio to the configuration structure and fill it during dvb_attach(). This way, the driver can still call it, and dvb_attach() will load stv090x module only if the device really needs it. Reported by: Jim Davis Cc: Luis Rodriguez Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed