From: Chris Larson <clarson@mvista.com>
Date: Fri, 22 Jan 2010 21:35:51 +0000 (-0700)
Subject: recipe_sanity: check RRECOMMENDS/RCONFLICTS and make the message more comprehensible
X-Git-Tag: Release-2010-05/1~792
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a1ff5ef51501fa8f845cce44790f43bc77b89544;p=openembedded.git

recipe_sanity: check RRECOMMENDS/RCONFLICTS and make the message more comprehensible

Signed-off-by: Chris Larson <clarson@mvista.com>
---

diff --git a/classes/recipe_sanity.bbclass b/classes/recipe_sanity.bbclass
index d929da6319..9becf49384 100644
--- a/classes/recipe_sanity.bbclass
+++ b/classes/recipe_sanity.bbclass
@@ -1,16 +1,16 @@
 def __note(msg, d):
     bb.note("%s: recipe_sanity: %s" % (d.getVar("P", 1), msg))
 
-__recipe_sanity_badtargetvars = "RDEPENDS RPROVIDES"
-def bad_target_vars(cfgdata, d):
+__recipe_sanity_badruntimevars = "RDEPENDS RPROVIDES RRECOMMENDS RCONFLICTS"
+def bad_runtime_vars(cfgdata, d):
     if bb.data.inherits_class("native", d) or \
        bb.data.inherits_class("cross", d):
         return
 
-    for var in d.getVar("__recipe_sanity_badtargetvars", 1).split():
+    for var in d.getVar("__recipe_sanity_badruntimevars", 1).split():
         val = d.getVar(var, 0)
         if val and val != cfgdata.get(var):
-            __note("%s should not be set, but is set to '%s'" % (var, val), d)
+            __note("%s should be %s_${PN}" % (var, var), d)
 
 __recipe_sanity_reqvars = "DESCRIPTION"
 __recipe_sanity_reqdiffvars = "LICENSE"
@@ -133,7 +133,7 @@ python do_recipe_sanity () {
     can_remove_others(p, cfgdata, d)
     var_renames_overwrite(cfgdata, d)
     req_vars(cfgdata, d)
-    bad_target_vars(cfgdata, d)
+    bad_runtime_vars(cfgdata, d)
 }
 do_recipe_sanity[nostamp] = "1"
 #do_recipe_sanity[recrdeptask] = "do_recipe_sanity"