From: John Youn Date: Mon, 9 Aug 2010 20:56:11 +0000 (-0700) Subject: USB: xhci: Remove buggy assignment in next_trb() X-Git-Tag: v2.6.36-rc3~41^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a1669b2c64a9c8b031e0ac5cbf2692337a577f7c;p=pandora-kernel.git USB: xhci: Remove buggy assignment in next_trb() The code to increment the TRB pointer has a slight ambiguity that could lead to a bug on different compilers. The ANSI C specification does not specify the precedence of the assignment operator over the postfix operator. gcc 4.4 produced the correct code (increment the pointer and assign the value), but a MIPS compiler that one of John's clients used assigned the old (unincremented) value. Remove the unnecessary assignment to make all compilers produce the correct assembly. Signed-off-by: John Youn Signed-off-by: Sarah Sharp Cc: stable Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed