From: Axel Lin Date: Tue, 20 Jul 2010 22:19:49 +0000 (-0700) Subject: acerhdf: fix resource reclaim in error path X-Git-Tag: v2.6.36-rc1~579^2~39 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a0dba697eec78fb2d4e2b76b83104a2b251ae70d;p=pandora-kernel.git acerhdf: fix resource reclaim in error path Fix resource reclaim in below cases: 1. acerhdf_register_platform() does not properly handle platform_device_alloc() failure and platform_device_add() failure This patch adds error handing for acerhdf_register_platform(). 2. acerhdf_register_platform() return err with acerhdf_dev == NULL. as a result, acerhdf_unregister_platform() does not do resource reclaim in acerhdf_init() error path. This patch adds error handing for acerhdf_register_platform(), thus correct the error handing path in acerhdf_init(). goto out_err instead of err_unreg if acerhdf_register_platform() fail. 3. platform_device_del() should only used in error handling. Current implementation missed a platform_device_put() in acerhdf_exit. This patch fixes it by using platform_device_unregister() instead of platform_device_del() in acerhdf_unregister_platform. Signed-off-by: Axel Lin Acked-by: Peter Feuerer Cc: Matthew Garrett Acked-by: Borislav Petkov Signed-off-by: Andrew Morton Signed-off-by: Matthew Garrett --- Reading git-diff-tree failed