From: Chris Ball Date: Tue, 29 Mar 2011 04:46:12 +0000 (-0400) Subject: mmc: sdhci-pci: Fix error case in sdhci_pci_probe_slot() X-Git-Tag: v2.6.39-rc6~4^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fdcdbb0d84922e7ccda2f717a04ea62629f7e18;p=pandora-kernel.git mmc: sdhci-pci: Fix error case in sdhci_pci_probe_slot() If pci_ioremap_bar() fails during probe, we "goto release;" and free the host, but then we return 0 -- which tells sdhci_pci_probe() that the probe succeeded. Since we think the probe succeeded, when we unload sdhci we'll go to sdhci_pci_remove_slot() and it will try to dereference slot->host, which is now NULL because we freed it in the error path earlier. The patch simply sets ret appropriately, so that sdhci_pci_probe() will detect the failure immediately and bail out. Signed-off-by: Chris Ball Cc: --- Reading git-diff-tree failed