From: Jingoo Han Date: Fri, 8 Mar 2013 02:38:26 +0000 (-0800) Subject: leds: leds-ns2: set devm_gpio_request_one() flags param correctly X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~22^2~13 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9d04cbaadf563db3ba04426c317d3e84bc27bac1;p=pandora-kernel.git leds: leds-ns2: set devm_gpio_request_one() flags param correctly The devm_gpio_request_one() flags parameter was set to: GPIOF_DIR_OUT | gpio_get_value(template->cmd) GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below: GPIOF_DIR_OUT (0 << 0) GPIOF_DIR_IN (1 << 0) So, when 'gpio_get_value(template->cmd)' is 1, the gpio pin can be set as input, instead of output. To prevent this problem, GPIOF_OUT_INIT flags should be used when using devm_gpio_request_one(). Same goes for 'gpio_get_value(template->slow)' case. Signed-off-by: Jingoo Han Signed-off-by: Bryan Wu --- Reading git-diff-tree failed