From: Steven Rostedt (Red Hat) Date: Wed, 19 Nov 2014 00:13:25 +0000 (-0500) Subject: ftrace/x86: Add frames pointers to trampoline as necessary X-Git-Tag: omap-for-v3.19/fixes-rc1~139^2~34 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9960efeb80f73bd073483dab0855ee0ddc27085c;p=pandora-kernel.git ftrace/x86: Add frames pointers to trampoline as necessary When CONFIG_FRAME_POINTERS are enabled, it is required that the ftrace_caller and ftrace_regs_caller trampolines set up frame pointers otherwise a stack trace from a function call wont print the functions that called the trampoline. This is due to a check in __save_stack_address(): #ifdef CONFIG_FRAME_POINTER if (!reliable) return; #endif The "reliable" variable is only set if the function address is equal to contents of the address before the address the frame pointer register points to. If the frame pointer is not set up for the ftrace caller then this will fail the reliable test. It will miss the function that called the trampoline. Worse yet, if fentry is used (gcc 4.6 and beyond), it will also miss the parent, as the fentry is called before the stack frame is set up. That means the bp frame pointer points to the stack of just before the parent function was called. Link: http://lkml.kernel.org/r/20141119034829.355440340@goodmis.org Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x86@kernel.org Cc: stable@vger.kernel.org # 3.7+ Acked-by: Thomas Gleixner Signed-off-by: Steven Rostedt --- Reading git-diff-tree failed