From: Axel Lin Date: Sat, 18 Sep 2010 05:13:28 +0000 (+0800) Subject: Regulator: lp3972 cleanup X-Git-Tag: v2.6.37-rc1~56^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=993af7c048f414121bc81e0d6e69456e3862a06b;p=pandora-kernel.git Regulator: lp3972 cleanup This patch includes below fixes based on Mark's comment. - Return actual error if i2c_smbus_read_byte_data() fail - Add spaces around bitwise AND operator(&) to improve readability - Add comment to explain why we need to update voltage change control register for LDO1 and LDO5 - Logging the value for diagnostics if chip reported incorrect voltage value - Add __devinit annotation for setup_regulators() - Show system control register1 value if the value is mismatched - Logging the value for diagnostics if failed to detect device Signed-off-by: Axel Lin Acked-by: Mark Brown Signed-off-by: Liam Girdwood --- Reading git-diff-tree failed