From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 15 Aug 2015 15:30:31 +0000 (-0400)
Subject: ext4: simplify some code in read_mmp_block()
X-Git-Tag: omap-for-v4.3/fixes-rc1~107^2~3
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9810446836ab5a4b34a749bb77f3eb5836f982cc;p=pandora-kernel.git

ext4: simplify some code in read_mmp_block()

My static check complains because we have:

	if (!*bh)
		return -ENOMEM;
	if (*bh) {

The second check is unnecessary.

I've simplified this code by moving the "if (!*bh)" checks around.  Also
Andreas Dilger says we should probably print a warning if sb_getblk()
fails.

[ Restructured the code so that we print a warning message as well if
  the mmp block doesn't check out, and to print the error code to
  disambiguate between the error cases.  - TYT ]

Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

Reading git-diff-tree failed