From: Nicholas Bellinger Date: Wed, 14 Mar 2012 01:20:11 +0000 (-0700) Subject: iscsi-target: Fix reservation conflict -EBUSY response handling bug X-Git-Tag: v3.2.12~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=980b16ee8122615e15197b0a747d924c3b35b6bd;p=pandora-kernel.git iscsi-target: Fix reservation conflict -EBUSY response handling bug commit 00fdc6bbef77844ce397a7de7acfaf25e8e2e4eb upstream. This patch addresses a iscsi-target specific bug related to reservation conflict handling in iscsit_handle_scsi_cmd() that has been causing reservation conflicts to complete and not fail as expected due to incorrect errno checking. The problem occured with the change to return -EBUSY from transport_generic_cmd_sequencer() -> transport_generic_allocate_tasks() failures, that broke iscsit_handle_scsi_cmd() checking for -EINVAL in order to invoke a non GOOD status response. This was manifesting itself as data corruption with legacy SPC-2 reservations, but also effects iscsi-target LUNs with SPC-3 persistent reservations. This bug was originally introduced in lio-core commit: commit 03e98c9eb916f3f0868c1dc344dde2a60287ff72 Author: Nicholas Bellinger Date: Fri Nov 4 02:36:16 2011 -0700 target: Address legacy PYX_TRANSPORT_* return code breakage Reported-by: Martin Svec Cc: Martin Svec Cc: Christoph Hellwig Signed-off-by: Nicholas Bellinger Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed