From: Andy Shevchenko Date: Wed, 7 May 2014 07:56:24 +0000 (+0300) Subject: dmaengine: dw: went back to plain {request,free}_irq() calls X-Git-Tag: omap-for-v3.16/fixes-against-rc1~137^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97977f7576a89cb9436c000ae703c0d515e748ac;p=pandora-kernel.git dmaengine: dw: went back to plain {request,free}_irq() calls The commit dbde5c29 "dw_dmac: use devm_* functions to simplify code" turns probe function to use devm_* helpers and simultaneously brings a regression. We need to ensure irq is disabled, followed by ensuring that don't schedule any more tasklets and then its safe to use tasklet_kill(). The free_irq() will ensure that the irq is disabled and also wait till all scheduled interrupts are executed by invoking synchronize_irq(). So we need to only do tasklet_kill() after invoking free_irq(). Signed-off-by: Andy Shevchenko Cc: stable@vger.kernel.org # v3.11+ Signed-off-by: Vinod Koul --- Reading git-diff-tree failed