From: Julia Lawall Date: Sun, 13 Dec 2009 01:41:29 +0000 (+0000) Subject: drivers/net/sfc: Correct code taking the size of a pointer X-Git-Tag: v2.6.33-rc1~59^2~15 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94de803db748b902a9442fcfd7aad31a2fde43b7;p=pandora-kernel.git drivers/net/sfc: Correct code taking the size of a pointer The function efx_iterate_state contains the code memcpy(&payload->msg, payload_msg, sizeof(payload_msg)); This is the only use of payload_msg. The type of payload_msg is changed from a pointer to an array, so that the result of sizeof really is the length of the string. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression *x; expression f; type T; @@ *f(...,(T)x,...) // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller --- Reading git-diff-tree failed