From: Jeff Moyer Date: Mon, 5 Mar 2012 15:19:52 +0000 (-0500) Subject: ext4: clean up the flags passed to __blockdev_direct_IO X-Git-Tag: v3.4-rc1~75^2~31 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93ef8541d5c3ad1a73057ff358a49d0ee7146d6f;p=pandora-kernel.git ext4: clean up the flags passed to __blockdev_direct_IO For extent-based files, you can perform DIO to holes, as mentioned in the comments in ext4_ext_direct_IO. However, that function passes DIO_SKIP_HOLES to __blockdev_direct_IO, which is *really* confusing to the uninitiated reader. The key, here, is that the get_block function passed in, ext4_get_block_write, completely ignores the create flag that is passed to it (the create flag is passed in from the direct I/O code, which uses the DIO_SKIP_HOLES flag to determine whether or not it should be cleared). This is a long-winded way of saying that the DIO_SKIP_HOLES flag is ultimately ignored. So let's remove it. Signed-off-by: Jeff Moyer Signed-off-by: "Theodore Ts'o" --- Reading git-diff-tree failed