From: Krzysztof Kozlowski Date: Mon, 29 Sep 2014 12:42:18 +0000 (+0200) Subject: dmaengine: pl330: Remove non-NULL check for pl330_submit_req parameters X-Git-Tag: fixes-against-v3.18-rc2~40^2~14 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=937cb2f2498dcbd8bcf6d79dcc24e5c8a3627067;p=pandora-kernel.git dmaengine: pl330: Remove non-NULL check for pl330_submit_req parameters The pl330_submit_req() checked supplied 'struct pl330_thread thrd' and 'struct dma_pl330_desc desc' parameters for non-NULL. However these checks are useless because supplied arguments won't be NULL. The pl330_submit_req() is called in only one place and: 1. 'desc' is already dereferenced in fill_queue() before calling pl330_submit_req(). 2. 'thrd' is always dereferenced after calling fill_queue()->pl330_submit_req(). Removing the checks for non-NULL values fixes following warning: drivers/dma/pl330.c:1376 pl330_submit_req() warn: variable dereferenced before check 'thrd' (see line 1367) Signed-off-by: Krzysztof Kozlowski Signed-off-by: Vinod Koul --- Reading git-diff-tree failed