From: Eric Sandeen <sandeen@redhat.com>
Date: Fri, 30 Mar 2012 16:24:11 +0000 (-0500)
Subject: Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
X-Git-Tag: v3.12-rc1~80^2~2
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=914ed44b17dc30ce0d783e8e23fce58a1a92412c;p=pandora-kernel.git

Fix wrong flag ASSERT in xfs_attr_shortform_getvalue

This ASSERT is testing an if_flags flag value against
a di_aformat enum value.  di_aformat is never assigned
XFS_IFINLINE.

This happens to work for now, because XFS_IFINLINE has
the same value as XFS_DINODE_FMT_LOCAL, and that's tested
just before we call this function.

However, I think the intention is to assert that we have
read in the data, i.e. XFS_IFINLINE on if_flags, before
we use if_data.  This is done in other places through the
code as well.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
---

Reading git-diff-tree failed