From: Robert Love Date: Fri, 6 Jul 2012 17:40:20 +0000 (-0700) Subject: [SCSI] fcoe: Remove redundant 'less than zero' check X-Git-Tag: v3.6-rc1~103^2~27 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=902a45af5c9fad283a530c3bc71225fa6a8e616a;p=pandora-kernel.git [SCSI] fcoe: Remove redundant 'less than zero' check strtoul returns an 'unsigned long' so there is no reason to check if the value is less than zero. strtoul already checks for the '-' character deep in its bowels. It will return an error if the user has provided a negative value and fcoe_str_to_dev_loss will return that error to its caller. This patch fixes the following Coverity reported warning: CID 703581 - NO_EFFECT Unsigned compared against 0 - This less-than-zero comparison of an unsigned value is never true. "*val < 0UL". drivers/scsi/fcoe/fcoe_sysfs.c:105 Signed-off-by: Robert Love Signed-off-by: James Bottomley --- Reading git-diff-tree failed