From: H Hartley Sweeten Date: Fri, 20 Sep 2013 23:44:08 +0000 (-0700) Subject: staging: comedi: pcl711: no need to calc the timer values twice X-Git-Tag: omap-for-v3.13/fixes-for-merge-window-take2~62^2~657 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8fbf1f4569634e950c1ebc46b0bad612ea404b00;p=pandora-kernel.git staging: comedi: pcl711: no need to calc the timer values twice The comedi core always calls the (*do_cmdtest) function to validate a command before it calls the (*do_cmd) function. Since the (*do_cmdtest) has already calculated the timer values in order to validate the cmd->scan_begin_arg there is no reason to recalc the values in the (*do_cmd). This also fixes a bug in the driver. The (*do_cmdtest) was using a time base value of 100 and but the (*do_cmd) was using a time base of 500. These result in different timer values. The functions used to calculate the values are actually the same due to a #define in the 8253.h header. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed