From: Chris Wilson <chris@chris-wilson.co.uk>
Date: Sun, 22 Aug 2010 09:54:23 +0000 (+0100)
Subject: drm/i915: Tightly scope intel_encoder to prevent invalid use
X-Git-Tag: v2.6.36-rc4~94^2~8
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e647a279ca30029f19eca646de08a6338eab924;p=pandora-kernel.git

drm/i915: Tightly scope intel_encoder to prevent invalid use

We reset intel_encoder for every matching encoder whilst iterating over
the encoders attached to this crtc when changing mode. As such in a
cloned configuration intel_encoder may not correspond to the correct
is_edp encoder.

By scoping intel_encoder to the loop, not only is the compiler able to
spot this mistake, we also improve readiability for ourselves.
[It might not be a mistake, within this function it is unclear as to
whether it is permissable for eDP to be cloned...]

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---

Reading git-diff-tree failed