From: Eric Dumazet Date: Mon, 14 Jan 2008 06:31:44 +0000 (-0800) Subject: [FIB]: full_children & empty_children should be uint, not ushort X-Git-Tag: v2.6.25-rc1~1162^2~757 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8d96544475b236a0f319e492f4828aa8c0801c7f;p=pandora-kernel.git [FIB]: full_children & empty_children should be uint, not ushort If declared as unsigned short, these fields can overflow, and whole trie logic is broken. I could not make the machine crash, but some tnode can never be freed. Note for 64 bit arches : By reordering t_key and parent in [node, leaf, tnode] structures, we can use 32 bits hole after t_key so that sizeof(struct tnode) doesnt change after this patch. Signed-off-by: Eric Dumazet Signed-off-by: Robert Olsson Signed-off-by: David S. Miller --- Reading git-diff-tree failed