From: Julia Lawall Date: Sun, 29 Dec 2013 22:47:27 +0000 (+0100) Subject: HID: sony: fix error return code X-Git-Tag: v3.14-rc1~129^2^4~10 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8cd5fcda24b48b162699730da7ead7329b27159e;p=pandora-kernel.git HID: sony: fix error return code Currently the return variable ret is always 0. Set it to other values in error cases, as used in the direct return. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Julia Lawall Signed-off-by: Jiri Kosina --- Reading git-diff-tree failed