From: Thadeu Lima de Souza Cascardo Date: Sun, 28 Nov 2010 21:46:50 +0000 (-0200) Subject: wmi: use memcmp instead of strncmp to compare GUIDs X-Git-Tag: v2.6.37-rc6~42^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b14d7b22c61f17ccb869e0047d9df6dd9f50a9f;p=pandora-kernel.git wmi: use memcmp instead of strncmp to compare GUIDs While looking for the duplicates in /sys/class/wmi/, I couldn't find them. The code that looks for duplicates uses strncmp in a binary GUID, which may contain zero bytes. The right function is memcmp, which is also used in another section of wmi code. It was finding 49142400-C6A3-40FA-BADB-8A2652834100 as a duplicate of 39142400-C6A3-40FA-BADB-8A2652834100. Since the first byte is the fourth printed, they were found as equal by strncmp. Signed-off-by: Thadeu Lima de Souza Cascardo Signed-off-by: Matthew Garrett Cc: stable@kernel.org --- Reading git-diff-tree failed