From: Julia Lawall Date: Sun, 19 Feb 2012 09:43:32 +0000 (+0000) Subject: drivers/atm/solos-pci.c: exchange pci_iounmaps X-Git-Tag: v3.3-rc6~36^2~28 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ae0cfee2a727f698bda12e530f4879a9793c6c9;p=pandora-kernel.git drivers/atm/solos-pci.c: exchange pci_iounmaps The calls to pci_iounmap are in the wrong order, as compared to the associated calls to pci_iomap. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,x; statement S,S1; int ret; @@ e = pci_iomap(x,...) ... when != pci_iounmap(x,e) if (<+...e...+>) S ... when any when != pci_iounmap(x,e) *if (...) { ... when != pci_iounmap(x,e) return ...; } ... when any pci_iounmap(x,e); // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller --- Reading git-diff-tree failed