From: Christoph Lameter Date: Tue, 17 Jan 2012 15:27:31 +0000 (-0600) Subject: slub: Do not hold slub_lock when calling sysfs_slab_add() X-Git-Tag: v3.2.14~22 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8a9de9cde83d1c913bcbe5bd8c6291f5536a576c;p=pandora-kernel.git slub: Do not hold slub_lock when calling sysfs_slab_add() commit 66c4c35c6bc5a1a452b024cf0364635b28fd94e4 upstream. sysfs_slab_add() calls various sysfs functions that actually may end up in userspace doing all sorts of things. Release the slub_lock after adding the kmem_cache structure to the list. At that point the address of the kmem_cache is not known so we are guaranteed exlusive access to the following modifications to the kmem_cache structure. If the sysfs_slab_add fails then reacquire the slub_lock to remove the kmem_cache structure from the list. Reported-by: Sasha Levin Acked-by: Eric Dumazet Signed-off-by: Christoph Lameter Signed-off-by: Pekka Enberg Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed