From: Guillaume Chazarain Date: Fri, 21 Jul 2006 21:45:25 +0000 (-0700) Subject: [PKT_SCHED] netem: Fix slab corruption with netem (2nd try) X-Git-Tag: v2.6.18-rc3~59^2~16 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89e1df74f841fc31e81838d30594c4eff01859f8;p=pandora-kernel.git [PKT_SCHED] netem: Fix slab corruption with netem (2nd try) CONFIG_DEBUG_SLAB found the following bug: netem_enqueue() in sch_netem.c gets a pointer inside a slab object: struct netem_skb_cb *cb = (struct netem_skb_cb *)skb->cb; But then, the slab object may be freed: skb = skb_unshare(skb, GFP_ATOMIC) cb is still pointing inside the freed skb, so here is a patch to initialize cb later, and make it clear that initializing it sooner is a bad idea. [From Stephen Hemminger: leave cb unitialized in order to let gcc complain in case of use before initialization] Signed-off-by: Guillaume Chazarain Signed-off-by: David S. Miller --- Reading git-diff-tree failed