From: Dan Carpenter Date: Tue, 12 Oct 2010 23:36:19 +0000 (+0000) Subject: pch_gbe: fix if condition in set_settings() X-Git-Tag: v2.6.37-rc1~147^2~138 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89980827c7a1e3c2b36895c22c6ef0e92aea6b0c;p=pandora-kernel.git pch_gbe: fix if condition in set_settings() There were no curly braces in this if condition so it always enabled full duplex. And ecmd->speed is an unsigned short so it is never equal to -1. The effect is that mii_ethtool_sset() fails with -EINVAL and an error is printed to dmesg. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- Reading git-diff-tree failed