From: Thomas Graf Date: Fri, 2 Jan 2015 22:00:18 +0000 (+0100) Subject: nft_hash: Remove rhashtable_remove_pprev() X-Git-Tag: omap-for-v4.1/prcm-dts-mfd-syscon-fix~134^2~294^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=897362e446436d245972e72c6bc5b33bd7a5c659;p=pandora-kernel.git nft_hash: Remove rhashtable_remove_pprev() The removal function of nft_hash currently stores a reference to the previous element during lookup which is used to optimize removal later on. This was possible because a lock is held throughout calling rhashtable_lookup() and rhashtable_remove(). With the introdution of deferred table resizing in parallel to lookups and insertions, the nftables lock will no longer synchronize all table mutations and the stored pprev may become invalid. Removing this optimization makes removal slightly more expensive on average but allows taking the resize cost out of the insert and remove path. Signed-off-by: Thomas Graf Cc: netfilter-devel@vger.kernel.org Signed-off-by: David S. Miller --- Reading git-diff-tree failed