From: Dan Carpenter Date: Fri, 15 Jun 2012 00:20:44 +0000 (+0000) Subject: can: c_can: precedence error in c_can_chip_config() X-Git-Tag: v3.2.22~22 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=86f65876182c72dfae0f7d1ecd619f6fc39b1ff0;p=pandora-kernel.git can: c_can: precedence error in c_can_chip_config() commit d9cb9bd63eb27ac19f26a8547128c053f43a5da8 upstream. (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which is zero so the condition is never true. The intent here was to test that both flags were set. Signed-off-by: Dan Carpenter Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed