From: James Bottomley Date: Fri, 22 Apr 2011 15:39:59 +0000 (-0500) Subject: [SCSI] put stricter guards on queue dead checks X-Git-Tag: v2.6.39-rc6~16^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=86cbfb5607d4b81b1a993ff689bbd2addd5d3a9b;p=pandora-kernel.git [SCSI] put stricter guards on queue dead checks SCSI uses request_queue->queuedata == NULL as a signal that the queue is dying. We set this state in the sdev release function. However, this allows a small window where we release the last reference but haven't quite got to this stage yet and so something will try to take a reference in scsi_request_fn and oops. It's very rare, but we had a report here, so we're pushing this as a bug fix The actual fix is to set request_queue->queuedata to NULL in scsi_remove_device() before we drop the reference. This causes correct automatic rejects from scsi_request_fn as people who hold additional references try to submit work and prevents anything from getting a new reference to the sdev that way. Cc: stable@kernel.org Signed-off-by: James Bottomley --- Reading git-diff-tree failed