From: H Hartley Sweeten Date: Mon, 10 Jun 2013 17:15:55 +0000 (-0700) Subject: staging: comedi: pcl724: tidy up subdev_8255_init() calls X-Git-Tag: omap-for-v3.11/fixes-for-merge-window~76^2~176 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84f7db9d8f9ee9bcee16143aab93b68b43e7e5cc;p=pandora-kernel.git staging: comedi: pcl724: tidy up subdev_8255_init() calls subdev_8255_init() can fail, make sure to check for it and return the errno. The private function subdev_8255_cb() is identical to the default io callback used by the 8255 driver. Remove it and pass NULL to subdev_8255_init() so the default callback will be used. The private function subdev_8255mapped_cb() is used for the memory memory mapped io of the pet48dio board. Rename this function so it has namespace associated with the driver. Casting the iobase passed to subdev_8255_init() is not needed. Use a local variable for the iobase and remove the casts. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed