From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Mon, 25 Sep 2006 23:39:22 +0000 (-0700)
Subject: [PATCH] Signedness issue in drivers/net/phy/phy_device.c
X-Git-Tag: v2.6.19-rc1~897^2~22
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84c22d7901f793bd267b5f79270080964b252826;p=pandora-kernel.git

[PATCH] Signedness issue in drivers/net/phy/phy_device.c

While checking gcc 4.1 -Wextra warnings, I stumbled across the following
two warnings:

drivers/net/phy/phy_device.c:528: warning: comparison of unsigned expression < 0 is always false
drivers/net/phy/phy_device.c:546: warning: comparison of unsigned expression < 0 is always false

Since phy_read() returns an integer and can return negative values, it seems
to me the best way to get proper error handling working again is to make val
an int.  Currently it is an u32, so the < 0 check always fails.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---

Reading git-diff-tree failed