From: David Brownell Date: Thu, 11 Sep 2008 06:01:24 +0000 (-0700) Subject: mach-omap2: fix more arch_initcall() breakage X-Git-Tag: v2.6.27-omap1~208 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=846fe83eec802587777fef31d80c967cfcf7d700;p=pandora-kernel.git mach-omap2: fix more arch_initcall() breakage Remove more bogus arch_initcall() logic in mach-omap2/board-xyx.c files. They broke a multi-OMAP build I did, at *RUN TIME* not build time, since it tried to do the i2c init for every board linked in the kernel. Remember, init_machine() entries run at arch_initcall() time; that's where any board-specific init logic should normally go. Any initcalls in the mach-*/*c files should normally be guarded by tests to make sure they only run on the relevant hardware (board, cpu). Better yet, get rid of the initcalls; init_machine() can *explicitly* call the right version of that code, and pass in board-specific config data; and there are hooks that can handle cpu-specific stuff too. A quick glance suggests most of the remaining initcall logic in the mach-omap2 directory is similarly broken... this patch gets rid of one frequently-cloned idiom, it should help. Signed-off-by: David Brownell Signed-off-by: Tony Lindgren --- Reading git-diff-tree failed