From: Sage Weil Date: Wed, 24 Aug 2011 21:07:01 +0000 (-0700) Subject: Revert "ceph: don't truncate dirty pages in invalidate work thread" X-Git-Tag: v3.2-rc1~126^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=83eaea22bdfc9e1cec88f81be5b64f30f6c37e8b;p=pandora-kernel.git Revert "ceph: don't truncate dirty pages in invalidate work thread" This reverts commit c9af9fb68e01eb2c2165e1bc45cfeeed510c64e6. We need to block and truncate all pages in order to reliably invalidate them. Otherwise, we could: - have some uptodate pages in the cache - queue an invalidate - write(2) locks some pages - invalidate_work skips them - write(2) only overwrites part of the page - page now dirty and uptodate -> partial leakage of invalidated data It's not entirely clear why we started skipping locked pages in the first place. I just ran this through fsx and didn't see any problems. Signed-off-by: Sage Weil --- Reading git-diff-tree failed