From: Andre Przywara <andre.przywara@arm.com>
Date: Tue, 25 Mar 2025 17:47:44 +0000 (+0000)
Subject: common: console: move break; statement
X-Git-Tag: v2025.07-rc1~89
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=82f5ce11e669d86ac08e6ba800d4a97ad734665b;p=pandora-u-boot.git

common: console: move break; statement

In console_setfile(), there is some #ifdef'ed code, updating monitor
functions for a U-Boot proper build. This is called inside a switch/case
statement, but the closing "break;" is inside the #ifdef section.
This doesn't look right: we should not fall through to the error case
for an SPL/TPL build.

Move the "break" to be always effective, solving a compiler warning about
an untagged implicit fallthrough.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
---

diff --git a/common/console.c b/common/console.c
index b69bb189639..275da2f264d 100644
--- a/common/console.c
+++ b/common/console.c
@@ -208,8 +208,8 @@ static int console_setfile(int file, struct stdio_dev * dev)
 			gd->jt->printf = printf;
 			break;
 		}
-		break;
 #endif
+		break;
 	default:		/* Invalid file ID */
 		error = -1;
 	}