From: Terry Loftin Date: Fri, 23 Oct 2009 01:36:01 +0000 (-0400) Subject: nfs: Panic when commit fails X-Git-Tag: v2.6.27.39~10 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8107fe51452d9213d5442a368ce710681b0c88c9;p=pandora-kernel.git nfs: Panic when commit fails commit a8b40bc7e635831b61c43acc71a86d3a68b2dff0 upstream. Actually pass the NFS_FILE_SYNC option to the server to avoid a Panic in nfs_direct_write_complete() when a commit fails. At the end of an nfs write, if the nfs commit fails, all the writes will be rescheduled. They are supposed to be rescheduled as NFS_FILE_SYNC writes, but the rpc_task structure is not completely intialized and so the option is not passed. When the rescheduled writes complete, the return indicates that they are NFS_UNSTABLE and we try to do another commit. This leads to a Panic because the commit data structure pointer was set to null in the initial (failed) commit attempt. Signed-off-by: Terry Loftin Signed-off-by: Trond Myklebust Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed