From: Julia Lawall <julia@diku.dk>
Date: Sun, 5 Sep 2010 09:00:22 +0000 (+0000)
Subject: i2c/i2c-pasemi.c: Fix unsigned return type
X-Git-Tag: v2.6.37-rc1~180^2~37
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8032214346c0c892e859cf6eee6c8ba305cbfe78;p=pandora-kernel.git

i2c/i2c-pasemi.c: Fix unsigned return type

The function has an unsigned return type, but returns a negative constant
to indicate an error condition.  The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Reading git-diff-tree failed