From: Julia Lawall Date: Wed, 1 Jun 2011 17:10:06 +0000 (+0200) Subject: drivers/usb/host/ohci-pxa27x.c: add missing clk_put X-Git-Tag: v3.0-rc3~29^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7febe2be36035e5c75128e8cc3baeb1f30fa2bc4;p=pandora-kernel.git drivers/usb/host/ohci-pxa27x.c: add missing clk_put Add a label before the call to clk_put and jump to that in the error handling code that occurs after the call to clk_get has succeeded. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression e1,e2; statement S; @@ e1 = clk_get@p1(...); ... when != e1 = e2 when != clk_put(e1) when any if (...) { ... when != clk_put(e1) when != if (...) { ... clk_put(e1) ... } * return@p3 ...; } else S // Signed-off-by: Julia Lawall Acked-by: Eric Miao Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed