From: Suman Anna <s-anna@ti.com>
Date: Fri, 28 Feb 2014 20:42:33 +0000 (-0600)
Subject: iommu/omap: Fix error return paths in omap_iommu_attach()
X-Git-Tag: v3.15-rc1~70^2^4~6
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7ee08b9ef2e942a5477f02a71947b933eb4101d2;p=pandora-kernel.git

iommu/omap: Fix error return paths in omap_iommu_attach()

There are couple of issues with the error return paths in
omap_iommu_attach():
1. omap_iommu_attach() returns NULL or ERR_PTR in case of error,
   but omap_iommu_attach_dev() only checks for IS_ERR. Thus a NULL
   return value (in case driver_find_device fails) will cause the
   kernel to panic when omap_iommu_attach_dev() dereferences the
   pointer.
2. A try_module_get() failure returns a valid success value as
   returned from iommu_enable().

Both the above issues have been fixed up to return the proper
ERR_PTR.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
---

Reading git-diff-tree failed