From: Peter Senna Tschudin Date: Mon, 19 May 2014 10:26:52 +0000 (+0200) Subject: atm: idt77252: Remove redundant error check X-Git-Tag: omap-for-v3.16/fixes-against-rc1~36^2~184 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7e910357f620bbebe5c5cb038b70d408e624522f;p=pandora-kernel.git atm: idt77252: Remove redundant error check Remove double checks, convert printk to pr_warn, and move the call to pr_warn to the first check. The simplified version of the coccinelle semantic patch that find this issue is as follows: // @@ expression E; identifier pr; expression list es; @@ while(...){ ... - if (E) break; + if (E){ + pr(es); + break; + } ... } - if(E) pr(es); // Tested by compilation only. Signed-off-by: Peter Senna Tschudin Signed-off-by: David S. Miller --- Reading git-diff-tree failed