From: Jesper Juhl Date: Thu, 12 Apr 2012 20:11:25 +0000 (+0200) Subject: ALSA: hda/realtek - Fix mem leak (and rid us of trailing whitespace). X-Git-Tag: v3.4-rc3~5^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d7eb9ea314e992413620610b4d09c9cd5fa8959;p=pandora-kernel.git ALSA: hda/realtek - Fix mem leak (and rid us of trailing whitespace). In sound/pci/hda/patch_realtek.c::alc_auto_fill_dac_nids(), in the 'for (;;)' loop, if the 'badness' value returned from fill_and_eval_dacs() is negative, then we'll return from the function without freeing the memory we allocated for 'best_cfg', thus leaking. Fix the leak by kfree()'ing the memory when badness is negative. While I was there I also noticed some trailing whitespace in the function that I removed (along with all other trailing whitespace in the file) - it didn't seem worth-while to do that as two patches, so I hope it's OK that I just did it all as one patch. Signed-off-by: Jesper Juhl Signed-off-by: Takashi Iwai --- Reading git-diff-tree failed