From: Sha Zhengju Date: Wed, 21 Aug 2013 08:27:34 +0000 (+0800) Subject: ceph: use vfs __set_page_dirty_nobuffers interface instead of doing it inside filesystem X-Git-Tag: v3.12-rc1~90^2~13 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d6e1f5461d0c16eb6aa8d226976995856d85e4e;p=pandora-kernel.git ceph: use vfs __set_page_dirty_nobuffers interface instead of doing it inside filesystem Following we will begin to add memcg dirty page accounting around __set_page_dirty_{buffers,nobuffers} in vfs layer, so we'd better use vfs interface to avoid exporting those details to filesystems. Since vfs set_page_dirty() should be called under page lock, here we don't need elaborate codes to handle racy anymore, and two WARN_ON() are added to detect such exceptions. Thanks very much for Sage and Yan Zheng's coaching! I tested it in a two server's ceph environment that one is client and the other is mds/osd/mon, and run the following fsx test from xfstests: ./fsx 1MB -N 50000 -p 10000 -l 1048576 ./fsx 10MB -N 50000 -p 10000 -l 10485760 ./fsx 100MB -N 50000 -p 10000 -l 104857600 The fsx does lots of mmap-read/mmap-write/truncate operations and the tests completed successfully without triggering any of WARN_ON. Signed-off-by: Sha Zhengju Reviewed-by: Sage Weil --- Reading git-diff-tree failed